Skip to content

fix(revert): ensure the call is joined before notifying readiness#2194

Merged
oliverlaz merged 1 commit intomainfrom
revert-2180-readiness-check
Apr 9, 2026
Merged

fix(revert): ensure the call is joined before notifying readiness#2194
oliverlaz merged 1 commit intomainfrom
revert-2180-readiness-check

Conversation

@oliverlaz
Copy link
Copy Markdown
Member

@oliverlaz oliverlaz commented Apr 9, 2026 •
edited by coderabbitai bot
Loading

Reverts #2180

ref: https://getstream.slack.com/archives/C06LKRKGZGQ/p1775731955118119

Summary by CodeRabbit

  • Refactor
    • Optimized egress readiness detection logic for improved performance and simplified state management.

@oliverlaz oliverlaz requested a review from jdimovska April 9, 2026 11:34
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: 50e2e1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@oliverlaz oliverlaz requested a review from RaphReynaud April 9, 2026 11:34
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4674cf36-1fda-409e-bab8-6c5671bc4d80

📥 Commits

Reviewing files that changed from the base of the PR and between f4fdd9e and 50e2e1e.

📒 Files selected for processing (1)
  • sample-apps/react/egress-composite/src/hooks/useNotifyEgress.tsx

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📝 Walkthrough

Walkthrough

Removed dependency on SDK call-state tracking from the egress notification hook. The readiness check now triggers solely based on the isReady flag rather than monitoring join state. The effect dependency array was simplified and a waiting status log statement was removed.

Changes

Cohort / File(s) Summary
Call State Dependency Removal
sample-apps/react/egress-composite/src/hooks/useNotifyEgress.tsx		 Removed dependency on CallingState tracking; readiness logic now relies exclusively on isReady flag. Simplified effect dependencies from [callingState, isReady] to [isReady] and removed early-return condition and waiting status log statement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With dependencies shed, the code grows lean,
One flag to follow, simple and clean,
No states to chase or logs to keep,
Just isReady whispers us gently to sleep! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-2180-readiness-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oliverlaz oliverlaz merged commit 1d6bf19 into main Apr 9, 2026
13 of 14 checks passed
@oliverlaz oliverlaz deleted the revert-2180-readiness-check branch April 9, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdimovska jdimovska jdimovska approved these changes

@RaphReynaud RaphReynaud Awaiting requested review from RaphReynaud

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverlaz @jdimovska